Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements #229 #239

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Implements #229 #239

wants to merge 4 commits into from

Conversation

Vioshim
Copy link

@Vioshim Vioshim commented Oct 5, 2024

Rationale

Through the new positional parameter in flags, it's possible to keep the traditional syntax yet being able to add the removing commands functionality, allowing us to remove each of them in a -1 -2 -3 fashion. It allows users to remove the commands from specific guilds as proposed originally in #229.

Summary of changes made

Instead of using a greedy str parameter, I've changed it for a flag converter which utilizes the greedy str within itself alongside a new "-" parameter which removes the slash commands from those guilds.

Checklist

  • This PR changes the jishaku module/cog codebase
    • These changes add new functionality to the module/cog
    • These changes fix an issue or bug in the module/cog
    • I have tested that these changes work on a production bot codebase
    • I have tested these changes against the CI/CD test suite
    • I have updated the documentation to reflect these changes
  • This PR changes the CI/CD test suite
    • I have tested my suite changes are well-formed (all tests can be discovered)
    • These changes adjust existing test cases
    • These changes add new test cases
  • This PR changes prose (such as the documentation, README or other Markdown/RST documents)
    • I have proofread my changes for grammar and spelling issues
    • I have tested that any changes regarding Markdown/RST syntax result in a well formed document

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant